-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating tests for Reverse-String exercise #1037
base: main
Are you sure you want to change the base?
Conversation
Did you write an example solution in C that deals with unicode and grapheme clusters? |
The current tests and example implementation do not handle wide characters, grapheme clusters, UTF, etc. It only handles 8-bit ASCII characters. So unless this exercise is radically changed then these tests should be marked as not implemented and the failing tests removed. It mat be a good addition to the track to have an exercise that handles such characters (I don't think we have any other such exercise). But I don't know if this should be that exercise, and I don't think such a change is within the scope of the simple update that was intended. |
Hi @wolf99, I've temporarily commented out these tests for now. If there's a more standardized or preferred approach, please let me know, and I'll make the necessary adjustments. I was considering using Apologies for the delay in revisiting this; I was tied up with exams. |
Pull Request: Update Test Suite for Reverse-String Exercise
This pull request updates the test suite for the Reverse-String exercise, bringing it in line with the latest problem specification. With this update, all tests for the exercise are now fully synchronized.