Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring sklearn notebooks - making them use the Secret Store #43

Merged
merged 11 commits into from
Nov 14, 2023

Conversation

ahsimb
Copy link
Collaborator

@ahsimb ahsimb commented Nov 8, 2023

closes #39

@ahsimb ahsimb added the refactoring Code improvement without behavior change label Nov 8, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

doc/tutorials/data/data_abalone.ipynb Show resolved Hide resolved
doc/tutorials/data/data_abalone.ipynb Outdated Show resolved Hide resolved
doc/tutorials/data/data_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_predict_abalone.ipynb Outdated Show resolved Hide resolved
ckunki
ckunki previously approved these changes Nov 13, 2023
doc/tutorials/data/data_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
@ahsimb
Copy link
Collaborator Author

ahsimb commented Nov 13, 2023

Oops! Thanks for spotting it. Will clear now.

doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/sklearn/sklearn_train_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/data/data_telescope.ipynb Outdated Show resolved Hide resolved
doc/tutorials/data/data_telescope.ipynb Outdated Show resolved Hide resolved
@ahsimb ahsimb merged commit 3bd4ba4 into main Nov 14, 2023
3 checks passed
@ahsimb ahsimb deleted the mibe-refactor-sklearn-notebooks branch November 14, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the Secret Store in the Learning-in-the-notebook tutorial
2 participants