Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of the SageMaker notebooks. #32

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

ahsimb
Copy link
Collaborator

@ahsimb ahsimb commented Nov 6, 2023

closes #12

Added dependency on ipywidgets

@ahsimb ahsimb added the feature Product feature label Nov 6, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,318 @@
{
Copy link
Collaborator

@tkilias tkilias Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reduce the instance type more, maybe to a ml.t3.medium?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am yet to learn what it means, so will go with your suggestion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/tutorials/sagemaker/sme_init.ipynb Show resolved Hide resolved
doc/tutorials/sagemaker/sme_init.ipynb Show resolved Hide resolved
doc/tutorials/sagemaker/sme_init_ui.ipynb Show resolved Hide resolved
@@ -0,0 +1,379 @@
{
Copy link
Collaborator

@tkilias tkilias Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to test the notebook later automatically, we need to implement the poll loop, instead of entrust the polling the user


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we make another ticket for this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please create a ticket for it.

@@ -0,0 +1,379 @@
{
Copy link
Collaborator

@tkilias tkilias Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, a feature which we could consider for the sagemaker extension


Reply via ReviewNB

@ahsimb ahsimb merged commit d928f96 into main Nov 14, 2023
3 checks passed
@ahsimb ahsimb deleted the mibe-sagemaker-notebooks branch November 14, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Notebook(s) to showcase sagemaker-extension
2 participants