New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#301 cloud front distribution for example data s3 bucket #311

Merged

ckunki merged 65 commits into main from feature/#301-CloudFront_Distribution_for_Example_Data_S3_Bucket

Aug 8, 2024

Contributor

ckunki commented Jul 25, 2024 •

edited

Loading

Closes #301

About mocking click CLI applications, see https://stackoverflow.com/questions/39183741/how-to-mock-components-within-unit-tests-for-click-based-cli-applications

ckunki added 30 commits

July 18, 2024 10:18


           #301: Added CloudFront distribution for example data S3 bucket

efd1342


           #301: Added CloudFront distribution for example data S3 bucket

42e887e


          Replaced vm_dss_bucket.py by generic class in s3/buckets.py

Updated tests


          Added class s3/waf.py:Waf

7b36753


          formatting

d71bd64


          Refactored vm_dss_bucket_waf.py

658608f


          renamed LogType

c217dea


          Removed dead code

d589d9b


          Fixed typo

5c7a5eb


          Merge branch 'main' into refactoring/#301-Refactor_bucket_handling

4bd0c3c


          Fixed changes file

844c0fa


          Refactored initial proposal

3731e8f


          updated imports

b3c6a23


          Fixed descriptions

0bfa155


          Update more descriptions

69da750


          Merge branch 'main' into refactoring/#301-Refactor_bucket_handling

0a4ffd9


          Fixed some review findings

17efd66


          Renamed classes, files, and folders wrt. review findings

52e83f2


          Merge branch 'main' into refactoring/#301-Refactor_bucket_handling

f02bb8c


          Added test verifying unchanged rendering of the cloudformation templates

f6f1e77


          Fixed review findings part 2

d3d2788


          [CodeBuild]

bbdb85e


          Added cloudformation templates for example data

fb9d01b


          Updated Developer Guide

a5333d8


          Renamed cli commands

5fb7ddf


          Added cli option --purpose to command setup_s3_bucket

f7b2847


          Added cli option --purpose to command setup_waf

98e7b26


          Added class ExampleDataCfTemplate

4674b72

updated tests and CLI


          Removed dead code and added comments on missing tests

bc24873


          Moved jinja templates for vm-images to different folder

141d1a1

tomuben reviewed

View reviewed changes

exasol/ds/sandbox/cli/commands/setup_s3_bucket.py Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

test/aws/mock_data.py Show resolved Hide resolved

tomuben reviewed

View reviewed changes

test/aws/mock_data.py Show resolved Hide resolved

tomuben reviewed

View reviewed changes

test/aws/mock_data.py Outdated Show resolved Hide resolved

tomuben reviewed

View reviewed changes

test/aws/mock_data.py Outdated Show resolved Hide resolved


          Added verification of region in test_s3_bucket_cf_template

e5db4dd

ckunki had a problem deploying to approve-test-execution

August 2, 2024 06:08

— with

GitHub Actions Failure

ckunki temporarily deployed to AWS_CI_TESTS

August 2, 2024 06:09

— with

GitHub Actions Inactive


          Fixed review findings

5ab21cb

ckunki had a problem deploying to approve-test-execution

August 2, 2024 06:40

— with

GitHub Actions Failure

ckunki temporarily deployed to AWS_CI_TESTS

August 2, 2024 06:41

— with

GitHub Actions Inactive

tomuben previously approved these changes

View reviewed changes

Collaborator

tkilias commented Aug 6, 2024

Here the other was to inject something into Click Commands

https://stackoverflow.com/questions/40443368/how-can-i-pass-a-ctx-context-to-clirunner


          Forward the region to Boto client even if user does not provide CLI o…

f7f4321

…ption --aws-profile

ckunki dismissed tomuben’s stale review via

f7f4321

August 6, 2024 13:27

ckunki had a problem deploying to approve-test-execution

August 6, 2024 13:27

— with

GitHub Actions Failure

ckunki temporarily deployed to AWS_CI_TESTS

August 6, 2024 13:28

— with

GitHub Actions Inactive


          [CodeBuild]

d3097b4

ckunki temporarily deployed to approve-test-execution

August 6, 2024 13:36

— with

GitHub Actions Inactive

ckunki temporarily deployed to AWS_CI_TESTS

August 6, 2024 13:37

— with

GitHub Actions Inactive

ckunki had a problem deploying to AWS_SAGEMAKER

August 6, 2024 14:03

— with

GitHub Actions Failure

ckunki temporarily deployed to AWS_SAGEMAKER

August 6, 2024 14:03

— with

GitHub Actions Inactive

ckunki temporarily deployed to AWS_SAGEMAKER

August 6, 2024 14:03

— with

GitHub Actions Inactive

ckunki temporarily deployed to AWS_SAGEMAKER

August 6, 2024 14:03

— with

GitHub Actions Inactive

ckunki had a problem deploying to AWS_SAGEMAKER

August 7, 2024 06:58

— with

GitHub Actions Failure

tkilias approved these changes

View reviewed changes

ckunki merged commit a2c4aa0 into main

9 of 10 checks passed

ckunki deleted the feature/#301-CloudFront_Distribution_for_Example_Data_S3_Bucket branch

August 8, 2024 08:30

ckunki mentioned this pull request

Fix differing versions of dependency scikit-learn #313

Closed

tkilias mentioned this pull request

CLI: setup-vm-bucket-waf: default value for cli option allowed-ip #21

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet