#295: Made notebook-tests mandatory for merge #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
tkilias
reviewed
Jun 24, 2024
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
tkilias
previously approved these changes
Jun 24, 2024
Additionally: Added logging options to pytest.ini for notebook tests
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
tkilias
reviewed
Jun 26, 2024
test/notebook_test_runner/test_notebooks_in_dss_docker_image.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Torsten Kilias <[email protected]>
ckunki
had a problem deploying
to
approve-test-execution
GitHub Actions
Failure
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
ckunki
temporarily deployed
to
approve-test-execution
GitHub Actions
Inactive
tkilias
reviewed
Jun 27, 2024
| modules = cleandoc( | ||
| """ | ||
| traitlets | ||
| luigi-interface |
There was a problem hiding this comment.
it is actually weird that you see this at all, because the itde handles its logging itself and should by default log only on warning
There was a problem hiding this comment.
However, it could be also, because it runs in pytest where logging is again a bit weird.
tkilias
approved these changes
Jun 27, 2024
ckunki
deleted the
refactoring/#295-Made_notebook-tests_mandatory_for_merge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295
Closes #193
Closes #297