#279 Made the nodebook testing running on SaaS [run-notebook-tests] #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicoretti
approved these changes
Jun 12, 2024
| @@ -17,6 +20,7 @@ | |||
| 'zero_shot_classification.ipynb' | |||
| ] | |||
| ) | |||
| @pytest.mark.skip(reason="The expected functionality is not yet implemented in the Transformers Extension") | |||
There was a problem hiding this comment.
I suggest using xfail with a reason. This is usually the safest strategy for adding tests for unimplemented things. Additionally, once implemented, the failure of xfail will indicate that the test should now be "enabled".
There was a problem hiding this comment.
With xfail the test still runs, which I don't want because it takes a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #279