fix: removing job due to required scopes not matching with token scope #408
Conversation
fix: removing job due to required scopes not matching with token scope
|
I see that your PR lacks an explanation why these changes are required. Providing one would help understanding your motivation and make the whole process of merging smoother. If you haven't provided a description because your PR isn't ready for review yet, let us know and we'll take a look once it is ready. Otherwise, I have a few questions:
Also, the styleci bot has found a few isues with your code formattting. Could you please apply the changes it suggests? |
| 'job_scopes' => $job->getScope(), | ||
| 'character_id' => $job->getToken()->character_id, | ||
| ]); | ||
| $job->delete(); |
There was a problem hiding this comment.
So you want to delete the job rather than have it fail because the job ran without the required scopes?
These types of errors are actually very useful to server owners like myself, to know when things are going wrong. Deleting it behind a Warning-type log is not ideal IMO
|
I agree that we should not be deleting these jobs. This PR is related to eveseat/seat#910 however I think the more appropriate diagnosis is to prevent jobs from being queued if they are not scoped for the job |
fix: removing job due to required scopes not matching with token scope