Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metadata standart for store NFT #370

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Lisska
Copy link

@Lisska Lisska commented Jun 7, 2024

No description provided.

@@ -1,10 +1,10 @@
---
title: 4.2. JSON Metadata
title: 4.2. On-chain JSON Metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are adding a new On-chain JSON Metadata standard and attempting to replace the existing TIP-4.2 JSON Metadata, this is a standard; you can't just delete it, there are assets based on this standard that developers will need to work with, and you've decided to remove information about it, considering that the proposed changes are significant, the correct approach would be to add TIP-4.7 On-chain JSON Metadata

P.S. As for the broken build, check the build logs — all the answers are there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Additionally, I kindly ask you to pay attention to the change history formation, there is a document that describes the process of making changes, it provides all the necessary instructions, if necessary, just squash the commits so that all these attempts to make the changes don't clutter up the main project history — there's no point in that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
see #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants