Do not style body element; Explicit classes for sponsors detail page #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Coles <[email protected]>
Signed-off-by: Alex Coles <[email protected]>
myabc
force-pushed
the
fix/sponsors-detail-page-background
branch
from
4da815e to
a728d05
Compare
|
I know from @wordgraphy that the sponsors details page was also put together in a rush last year, so there's big scope for improvement in the code (particularly removing unnecessary nesting of classes). Inconsistent pluralisation drives me crazy – for consistency's sake, this component should probably be called |
myabc
changed the title
See b86793b. Signed-off-by: Alex Coles <[email protected]>
See b86793b. Signed-off-by: Alex Coles <[email protected]>
bitboxer
added a commit
that referenced
this pull request
Jun 16, 2015
Do not style body element; Explicit classes for sponsors detail page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #20