Refactor EuTxManager Java to Kotlin

[serim53]

Refactor EuTxManager java to kotlin

• Related Issue : [Refactoring] EuTxManager java to kotlin #224

• Convert Java style code to Kotlin style (Kotlin block function)
• Change Handler to Coroutine Scope
• Versionize AudioTrack
  • Apply Builder Pattern
• Deprecate setMode() and convert into Kotlin format

[yeonns]

@serim53 Thank you for refactoring EuTxManager! It looks good 👍
One thing I wanna comment is that txCore is included at constructor. txCore is only used at EuTxManager internally, and its initialization is always same, so I think it would be removed at constructor. How about declaraing as private val?

And, EuTxManagerTest has unused imports, so how about removing it as well? 😄

[serim53]

@serim53 Thank you for refactoring EuTxManager! It looks good 👍 One thing I wanna comment is that txCore is included at constructor. txCore is only used at EuTxManager internally, and its initialization is always same, so I think it would be removed at constructor. How about declaraing as private val?

And, EuTxManagerTest has unused imports, so how about removing it as well? 😄

As you said, txcore is only used internally, so I also think it's better to move it to the internal code! I corrected this part and deleted the import, and I commited it again! Thank you for checking carefully! 🥰

[designe]

Hi! @serim53
Sorry for the late riview 😢

I read all your EuTxManager.kt code.

• By replacing Handler with corountine, android os dependency has disappeared, and flexibility seems to have been strengthened.
• In addition, readability enhancement was noticeable through AudioTrack's Builder pattern.

Overall, the refactored code seems to be neatly written.
I leave some review-comments here :)

[SeonJK]

Great contribution!

I read your codes and have some questions.

In deprecated functions; setMode() and setCode(), does it also call txCore.setMode() and txCore.setCode()?

[zion830]

The first Kotlin Transformation! 👍
I left some reviews about nullable :D

[designe]

@zion830 Thanks for your helpful review :)
@serim53 It's almost done ;) after modificaiton about @Deprecated annotation, It's done!

[serim53]

@zion830 Thanks for your helpful review :) @serim53 It's almost done ;) after modificaiton about @Deprecated annotation, It's done!

I finally modified all reviews! Thanks for your help!☺️

[yeonns]

@serim53 @zion830 Thank you for update! Now, it looks perfect!

[designe]

Since ReplaceWith does not yet support the properties of getter and setter roles, it seems that there is currently only a way to display it with a message.
For the rest, the same expression was expressed more concisely.

@serim53 Thanks for your great migration & refactoring!