Fix Bulk registration invalid MXID in requests #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a CSV without MXIDs (due to the #29), synapse-admin will generate random MXIDs, but for some reason, the bulk registration will attempt to put "mxid into mxid".
Let's assume the desired MXID is
@user:example.com. Bulk registration (again, with random MXID generation, I was not able to test with ids from csv due to mentioned above issue, but they may be affected as well) will check the existence of@user:example.com, and then will attempt to create@@user:example.com:example.com. So it looks like it just takes whatever value the generator func returns (full MXID) and concatenates it into@${MXID_FROM_GENERATOR_OR_WHATEVER}:${base_url}.That's entirely wrong - it should check if the input (either returned from generator, or from csv) is full MXID (
@user:example.com) or localpart (user) and correctly return full MXID in both casesfixes #30