Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect base url when loading config.json #274

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

aine-etke
Copy link
Member

@aine-etke aine-etke commented Jan 9, 2025

When using BASE_PATH env var or --base vite's option, config.json was still loaded as /config.json, ignoring the actual path.

This PR fixes Awesome-Technologies/synapse-admin#644 (idea from Awesome-Technologies/synapse-admin#652)

@aine-etke
Copy link
Member Author

@aine-etke aine-etke merged commit ddf3298 into main Jan 9, 2025
1 check passed
@aine-etke aine-etke deleted the respect-base-url-for-config-json branch January 9, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get config.json
1 participant