chore: remove state nodes from standard release process #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
requested review from
carver,
mrferris,
njgheorghita,
ogenev and
morph-dev
morph-dev
approved these changes
Feb 3, 2025
| @@ -61,11 +61,11 @@ This step directs Ansible to use the current master version of trin. Read [about | |||
| - Run the deployment: | |||
| - Trin nodes: | |||
| - `ansible-playbook playbook.yml --tags trin` | |||
| - State network nodes (check with the team if there is a reason not to update them): | |||
| <!-- - State network nodes (check with the team if there is a reason not to update them): | |||
| - Recently, we don't regularly deploy state bridge nodes (because they run for a long time and we don't want to restart them). To deploy all other state nodes, use following command: | |||
There was a problem hiding this comment.
nit: I believe that we can also remove lines 65:67.
KolbyML
force-pushed
the
remove-state-from-standard-release-process
branch
from
4bb6481 to
edd3e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
In todays Trin meeting it was agreed to take State nodes out of the standard release process for the time being.
The reason for this is the State Network is not ready for production and being able to iterate quicker should help us launch quicker as we will know if there is an issue quick and hence fix them quicker
How was it fixed?
Comment out the state network code, if someone wants I can remove it, but I thought to keep it as one day the state nodes will join the standard deployment process again