feat: add benchmark for trin #1660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
force-pushed
the
trin-benchmark
branch
from
11f54ab to
0d8c413
Compare
KolbyML
force-pushed
the
trin-benchmark
branch
3 times, most recently
from
0f8306b to
2a97753
Compare
KolbyML
force-pushed
the
trin-benchmark
branch
from
1203fc1 to
84850b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We didn't have a reliable way to test if we made a performance improvement or regression in Trin.
How was it fixed?
By building
trin-benchwhich contains three partsYou can set the era1 range you want to test with, then run the test which will generate flamegraphs so you can review what functions are using all our CPU cycles
TODO: in future PR's
add support for other Portal clients, so we can see how performent each client is relative to each other