fix: stop generate_random_remote_enr from generating multicast ip's
#1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
approved these changes
Feb 1, 2025
|
|
||
| // Generate an IP between 1.0.0.0 and 223.255.255.255 | ||
| // We don't want to generate a multicast address (224.0.0.0 - 239.255.255.255) | ||
| let ip = Ipv4Addr::from(rng.gen_range(1..=0xDFFFFFFF)); // 0xDFFFFFFF == 223.255.255.255 |
There was a problem hiding this comment.
If we want ip address to be in the 1.0.0.0 and 223.255.255.255 range, shouldn't this be:
rng.gen_range(0x01000000..=0xDFFFFFFF)
KolbyML
force-pushed
the
fix-generate-random-enr
branch
from
d75d991 to
5b64e5d
Compare
KolbyML
force-pushed
the
fix-generate-random-enr
branch
from
5b64e5d to
777a733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
generate_random_remote_enrwas generating Multicast ips, we usegenerate_random_remote_enr()in Hive tests and most clients don't allow Multicast IP's to be usedHow was it fixed?
Only generate IP's before the Multicast range and after 0.0.0.0