Publish sourcify-server and only publish the package in its own CI run #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes adds the sourcify-server package to be published to npm. It also adds a check to only publish the packages in their own tagged CI runs. Previously e.g. when there was a new tag for theese packages, both lib-sourcify and bytecode-utils's CI runs tried to publish both packages. This results in the first one succeeding and publishing both packages but the second one to fail. Now we check to only publish the package in their corresponding tag CI builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes adds the sourcify-server package to be published to npm.
It also adds a check to only publish the packages in their own tagged CI runs. Previously e.g. when there was a new tag for theese packages, both lib-sourcify and bytecode-utils's CI runs tried to publish both packages. This results in the first one succeeding and publishing both packages but the second one to fail.
Now we check to only publish the package in their corresponding tag CI builds.
Related to #1661. Still need to add the docs how to use the server package.
Edit: TBH I'd skip adding the docs because it's rather complicated to set up a
new Server()with options. I tried to do the fixes and it takes a lot of time. I'd postpone it until someone requests it and also until #1665