Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Add hive instance information endpoint #1198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 3, 2025

Adds a /hive endpoint to the server API that returns an object containing information about the hive instance that is currently running.

Hive info object contents

  • command: Command line used to start the hive server.
  • clientFile: Contents of the file specified in --client-file if any.
  • commit: Git commit used build the hive binary.
  • date: Date of build of the hive binary.

@fjl
Copy link
Collaborator

fjl commented Jan 8, 2025

I don't fully understand why this is a part of the simulation API. From discussion with @parithosh, I learned that this info is wanted for the purpose of displaying it in test results.

The simulation API is the endpoint for the simulator. The simulator doesn't really need to know the hive version. If hive wants to write information about itself into the output file, it can just do it.

@marioevz
Copy link
Member Author

marioevz commented Jan 8, 2025

I learned that this info is wanted for the purpose of displaying it in test results.

Yes that's the only reason.

The simulation API is the endpoint for the simulator. The simulator doesn't really need to know the hive version. If hive wants to write information about itself into the output file, it can just do it.

But isn't the simulator created by hive? We don't have any other way to communicate with hive, other than doing some hacky stuff like looking at which process is using the port and then somehow get the information about the output file.

Perhaps we could look it like a way of looking for the information about the hive version that was used to create the simulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants