Better error messages for JSON parsing #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
better-error-messages
branch
from
f0c3246 to
25b147b
Compare
msooseth
force-pushed
the
better-error-messages
branch
from
25b147b to
2bc3956
Compare
blishko
reviewed
Jan 23, 2025
Co-authored-by: Martin Blicha <[email protected]>
|
Haha, the Haskell constructs were a bit hard to do, I agree. But it's correct, I kinda promise :D Thanks for checking through. Strange that my spell checker didn't find that issue, thanks for picking it up!! Mate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We gave a VERY generic message for the JSON parser failures when parsing Forge JSONs. This fixes that, adding way better error messages.
Checklist