More Prop simplification rules #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blishko
reviewed
Jan 6, 2025
| @@ -1232,6 +1234,9 @@ simplifyProp prop = | |||
| go (PNeg (PBool b)) = PBool (Prelude.not b) | |||
| go (PNeg (PNeg a)) = a | |||
|
|
|||
| -- Empty buf | |||
| go (PEq (Lit 0) (BufLength k)) = peq k (ConcreteBuf "") | |||
There was a problem hiding this comment.
Are you sure this is a simplification?
Is it better on the SMT level to compare arrays instead of computing buffer length and comparing it to 0?
|
Not entirely sure… the Props look nicer to my human eyes though 😂 I can
remove it if you think it’s all the same/worse. What do you think?
Mate
…On Mon 6. Jan 2025 at 21:54, Martin Blicha ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/EVM/Expr.hs
<#628 (comment)>:
> @@ -1232,6 +1234,9 @@ simplifyProp prop =
go (PNeg (PBool b)) = PBool (Prelude.not b)
go (PNeg (PNeg a)) = a
+ -- Empty buf
+ go (PEq (Lit 0) (BufLength k)) = peq k (ConcreteBuf "")
Are you sure this is a simplification?
Is it better on the SMT level to compare arrays instead of computing
buffer length and comparing it to 0?
—
Reply to this email directly, view it on GitHub
<#628 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXYLY5B6JPMKNO3CWHWIGND2JLUQJAVCNFSM6AAAAABUWH5A4WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZSHE2TKNRQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I think it's OK. I was just thinking that if ever |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three more prop simplification rules.
Checklist