Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nixpkgs ghc96 #479

Closed
wants to merge 2 commits into from
Closed

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Mar 26, 2024

Description

To fix the upstream nixpkgs, I took few hours to tackle couple of issues I encountered.

I realized #471 is ongoing. So this may be duplicate work, partially.

What I did:

  1. I did want to see if I could make cabal --allow-newer --enable-tests --enable-bench build all work. In doing so, I was guided by -Wunused-packages option to remove bunch of red-herring dependency issues.
  2. I fixed build errors due to newer packages or ghc 9.6, some already present in Update GHC to 9.6 #471
    • I did not use the test suite thoroughly, since I am not familiar with hevm test suite.
  3. update nixpkgs flake input.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

`cabal --allow-newer --enable-tests --enable-bench build all`
@hellwolf hellwolf force-pushed the fix-nixpkgs-ghc96 branch from dd10fd1 to 2530d46 Compare March 26, 2024 11:17
@hellwolf hellwolf marked this pull request as draft March 26, 2024 11:40
@msooseth
Copy link
Collaborator

Hi! #471 has been merged. Do you think there are things that would be of interest to port? For example the red herring dependencies you found? Let me know what you think,

Mate

@hellwolf
Copy link
Contributor Author

Hi, I would really like to clean up the cabal file free of unused dependencies! I will work on this and send a patch.

@msooseth
Copy link
Collaborator

NICE. Thanks a lot! Looking forward :)

@hellwolf
Copy link
Contributor Author

@msooseth #518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants