Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effects: add TTY effect #420

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Effects: add TTY effect #420

merged 1 commit into from
Nov 7, 2023

Conversation

d-xo
Copy link
Collaborator

@d-xo d-xo commented Nov 7, 2023

Description

Adds a TTY effect that allows us to write to stdout and stderr using our new effects language

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo requested a review from msooseth November 7, 2023 14:34
msooseth
msooseth approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@msooseth msooseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

As discussed, we need this in order to have an ability to present a nice user interface (e.g. a progress bar) and to have slightly better debugging facilities (though maybe best to do that with files).

@msooseth msooseth merged commit 22162a5 into main Nov 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msooseth msooseth msooseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-xo @msooseth