Simplifying BufLength via bufLength #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoep
reviewed
Oct 20, 2023
| @@ -282,7 +282,12 @@ tests = testGroup "hevm" | |||
| ] | |||
| , testGroup "SimplifierUnitTests" | |||
| -- common overflow cases that the simplifier was getting wrong | |||
| [ testCase "writeWord-overflow" $ do | |||
| [ testCase "bufLength-simp" $ do | |||
There was a problem hiding this comment.
Would adding tests for more complicated buffer expressions (the involve writes perhaps to abstract buffers) make sense?
There was a problem hiding this comment.
Probably :) I wanted to keep this PR short and sweet. I didn't want to dig myself into bufLength -- it may be perfect, it may be possible to improve. I just wanted to make sure it's actually working and used 😄
Should we write a few more test cases? Perhaps that could be an issue I can tackle in another PR. I don't want to delay this PR too long. What do you think?
zoep
approved these changes
Oct 20, 2023
|
I'll add some more tests for other functionalities of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We accidentally removed(?) or never added(?) the
bufLengthcall to simplifyBufLength. Discovered this while writing a concrete fuzzer of Expr. This is a pretty funny one I think! :D Added a unit test to make sure we catch this next time!Checklist