remove gas #404
Closed
remove gas #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change has been merged already as part of another amazing PR, thanks for that! Closing this as this is a duplicate :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr entirely removes gas accounting from EVM.hs. It significantly simplifies the logic in EVM.hs, and removes a non trivial amount of code. The major downside here is that we can no longer:
I'm inclined to merge #352 or #403 instead of this since they allow us to run without gas while still letting us test vs geth. If we do decide to delete gas entirely, we would ideally generate a version of the evm conformance test suite that would represent a gasless semantics.
Checklist