Merge pull request #623 from ethereum/missing-override

Adding a note about prank and delegatecall
ethereum · Jan 2, 2025 · 20b36c2 · 20b36c2
2 parents 037ff11 + ab14ffb
commit 20b36c2
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/EVM.hs b/src/EVM.hs
@@ -952,6 +952,8 @@ exec1 = do
                   case gasTryFrom xGas of
                     Left _ -> vmError IllegalOverflow
                     Right gas ->
+                      -- NOTE: we don't update overrideCaller in this case because
+                      -- forge-std doesn't. see: https://github.com/foundry-rs/foundry/pull/8863
                       delegateCall this gas xTo' self (Lit 0) xInOffset xInSize xOutOffset xOutSize xs $
                         \_ -> touchAccount self
             _ -> underrun