ci: improvements #451
ci: improvements #451
Conversation
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.22 |
There was a problem hiding this comment.
Targeting the same version as the minimum required today in go-ethereum.
| runs-on: self-hosted | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
Running tests in three OSs.
| with: | ||
| go-version: 1.22 | ||
| - name: Test | ||
| run: go test -v -race ./... -timeout=15m |
There was a problem hiding this comment.
Looks like the macos-latest is a bit slow, so it requires a bit more time.
There was a problem hiding this comment.
Uhm, last run took 7m. But I saw at least one take >10min thus failing.
Let's keep 15m since maybe GH have different machines -- let's avoid potential false positives.
| @@ -33,7 +33,8 @@ import ( | |||
| "errors" | |||
| "fmt" | |||
| "io" | |||
| mRand "math/rand" | |||
| mRandV1 "math/rand" | |||
There was a problem hiding this comment.
can we not convert everything to v2?
There was a problem hiding this comment.
Unfortuantely no until we can use Go v1.23 which creates an API to do that exactly.
Why is |
Signed-off-by: Ignacio Hagopian <[email protected]>
|
I guess. Ok, let's do that. |
This PR improves the CI configuration to:
self-hostedfor build/lint/test. It isn't properly configured and took ~30min to run for no good reason (i.e: has an ever growing Go cache restoring).