use resolved to return Fis in stateless internal #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
master
branch
10 times, most recently
from
a91cff8 to
a6970ed
Compare
gballet
force-pushed
the
master
branch
8 times, most recently
from
1d4d60c to
a649f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Producing verifiable proofs requires to obtain
Fisfrom the tree. The problem withStatelessNodeuntil now, is that they didn't load all the values, and therefore producing theseFiswas impossible.Now that
ParseNodeloads all the values inunresolved, this becomes possible in some cases, and those cases correspond to the situation in which proofs have to be produced.This isn't working for stateless leaf nodes, so that PR will not be merged yet.