stateless: deactivate GetCommitmentsAlongPath #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ipa-stateless #156 +/- ##
=================================================
+ Coverage 85.07% 86.84% +1.77%
=================================================
Files 9 9
Lines 784 768 -16
=================================================
Hits 667 667
+ Misses 96 80 -16
Partials 21 21
Continue to review full report at Codecov.
|
gballet
added a commit
that referenced
this pull request
Jan 18, 2022
gballet
added a commit
that referenced
this pull request
Jan 19, 2022
* add stateless node * Add leaf insertion test and fix issues * fix the update calculation in stateless leaf insert * Add test for the insertion of a different value * add commitment calculation when inserting into leaf (#145) * fix commitment calculation in insert into leaf * fix insertion in leaf * deepsource fixes (#146) * Do not use an overwritten FrZero in tests (#147) * Do not use an overwritten FrZero * a more thorough fix: instantiate a new zero * fix delete + add test (#149) * stateless: coverage for InsertOrdered (#151) * stateless: add a test for copy (#152) * stateless: add test for Get (#153) * stateless: add a test for toDot and fix a commitment copy issue (#154) * stateless: deactivate GetCommitmentsAlongPath (#156) * fix deepsource error (#157) * move error definitions to doc.go (#158) * fix Children() and add test (#159) * add a test to check the corner case of the stateless root (#160) * changes for deserialization code to work (#177)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround until #155 has been tackled: panic when trying to call
GetCommitmentsAlongPath, as it is currently broken, and the need for that use case isn't immediately clear.