core/vm: simplify tracer hook invocation in interpreter loop #31074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
force-pushed
the
simplify-interpreter-loop
branch
from
ff9188c to
479ea11
Compare
jwasinger
changed the title
jwasinger
commented
Jan 25, 2025
jwasinger
commented
Jan 25, 2025
jwasinger
commented
Jan 25, 2025
|
Lint is failing, otherwise sgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes duplicate code in the interpreter loop.
The tradeoff is an additional conditional check in the hot loop of the interpreter, but this should not have a measurable performance impact. I can run the benchmarks to verify this at a later time.