Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evmmax: Initial implementation of EVMMAX instructions (EIP-6690) #742

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

evmmax: Fix after rebase

da87a62
Select commit
Loading
Failed to load commit list.
Open

evmmax: Initial implementation of EVMMAX instructions (EIP-6690) #742

evmmax: Fix after rebase
da87a62
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 28, 2025 in 1s

18.69% (-75.61%) compared to 9d28979

View this Pull Request on Codecov

18.69% (-75.61%) compared to 9d28979

Details

Codecov Report

Attention: Patch coverage is 4.00000% with 288 lines in your changes missing coverage. Please review.

Project coverage is 18.69%. Comparing base (9d28979) to head (da87a62).

Files with missing lines Patch % Lines
lib/evmmax/evmmax.cpp 4.16% 92 Missing ⚠️
test/unittests/evmmax_test.cpp 4.22% 68 Missing ⚠️
lib/evmone/instructions.hpp 0.00% 62 Missing ⚠️
test/unittests/evmmax_instructions_test.cpp 5.35% 53 Missing ⚠️
test/utils/bytecode.hpp 0.00% 12 Missing ⚠️
lib/evmone/baseline_execution.cpp 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9d28979) and HEAD (da87a62). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9d28979) HEAD (da87a62)
unittests 1 0
eof_execution_spec_tests 1 0
execution_spec_tests 1 0
ethereum_tests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #742       +/-   ##
===========================================
- Coverage   94.29%   18.69%   -75.61%     
===========================================
  Files         159      160        +1     
  Lines       17325    15636     -1689     
===========================================
- Hits        16337     2923    -13414     
- Misses        988    12713    +11725     
Files with missing lines Coverage Δ
include/evmmax/evmmax.hpp 100.00% <100.00%> (ø)
lib/evmone/advanced_instructions.cpp 2.43% <ø> (-97.57%) ⬇️
lib/evmone/execution_state.hpp 87.23% <100.00%> (-7.51%) ⬇️
test/unittests/eof_validation_test.cpp 0.00% <ø> (-99.42%) ⬇️
test/unittests/instructions_test.cpp 0.00% <ø> (-89.59%) ⬇️
lib/evmone/baseline_execution.cpp 63.04% <0.00%> (-36.96%) ⬇️
test/utils/bytecode.hpp 13.77% <0.00%> (-83.58%) ⬇️
test/unittests/evmmax_instructions_test.cpp 5.35% <5.35%> (ø)
lib/evmone/instructions.hpp 69.55% <0.00%> (-30.45%) ⬇️
test/unittests/evmmax_test.cpp 2.47% <4.22%> (-92.84%) ⬇️
... and 1 more

... and 137 files with indirect coverage changes