Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump base-org/contracts dep #367

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Bump base-org/contracts dep #367

merged 1 commit into from
Nov 7, 2024

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Nov 5, 2024 •
edited
Loading

Description

Bumps the base-org/contracts dep to pull in base-org/contracts#105, which fixes some issues we were having in #363.

@mdehoog mdehoog requested a review from a team as a code owner November 5, 2024 18:00
@mdehoog mdehoog requested a review from ajsutton November 5, 2024 18:00
Base automatically changed from aj/set-impl-fancy-template to main November 5, 2024 23:27
@mdehoog mdehoog requested a review from mds1 November 6, 2024 16:44
ajsutton
ajsutton approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. :) (but my approval doesn't count here...)

mds1
mds1 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mds1 mds1 added this pull request to the merge queue Nov 7, 2024
@mds1 mds1 mentioned this pull request Nov 7, 2024
Closed
Merged via the queue into main with commit 516972d Nov 7, 2024
13 checks passed
@mds1 mds1 deleted the michael/upgrade-base-contracts branch November 7, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdehoog @ajsutton @mds1