Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to re-initialize AnchorStateRegistry with additional game types #365

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Nov 1, 2024

Description

Adds an additional transaction template to #363 that re-initializes the AnchorStateRegistry to add an initial anchor state for new game types. The initial anchor state to use is taken from the current anchor state for another game type (at the time the just command is run so it's static in the resulting task definition).

This allows creating a task to enable permissionless fault proofs on a chain that previously only deployed permissioned games.

@ajsutton ajsutton requested review from a team as code owners November 1, 2024 03:48
@ajsutton ajsutton requested review from tynes, mds1 and Ethnical and removed request for a team November 1, 2024 03:48
mds1
mds1 previously approved these changes Nov 4, 2024
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #363, just needs to be updated now that #356 was merged

@ajsutton ajsutton force-pushed the aj/set-impl-fancy-template branch from ed6c36c to fb600bf Compare November 4, 2024 23:36
@ajsutton ajsutton force-pushed the aj/set-anchor-states branch from 76f78b3 to 8ddf271 Compare November 5, 2024 00:14
@ajsutton
Copy link
Contributor Author

ajsutton commented Nov 5, 2024

@mds1 Just a heads up, I wound up changing this one a bit. Because the initialize method writes the supplied anchor states to it's storage but doesn't delete any other existing entries from the map, we can make the operation safer by only setting the new anchor states and not overwriting the existing source anchor state. I added a post-check to confirm the source anchor state is still set.

Base automatically changed from aj/set-impl-fancy-template to main November 5, 2024 23:27
@ajsutton ajsutton dismissed mds1’s stale review November 5, 2024 23:27

The base branch was changed.

@ajsutton ajsutton force-pushed the aj/set-anchor-states branch from 262d73b to 52e6ef0 Compare November 6, 2024 19:46
@ajsutton ajsutton added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit efb0f73 Nov 6, 2024
13 checks passed
@ajsutton ajsutton deleted the aj/set-anchor-states branch November 6, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants