Fix a bunch of review feedback.

ethereum-optimism · Oct 29, 2024 · 3d3c16e · 3d3c16e
1 parent fa74643
commit 3d3c16e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/tasks/sep/fp-recovery/005-set-game-implementation/.env b/tasks/sep/fp-recovery/005-set-game-implementation/.env
@@ -1,5 +1,4 @@
 ETH_RPC_URL="https://ethereum-sepolia.publicnode.com"
-SUPERCHAIN_CONFIG_ADDR=0xC2Be75506d5724086DEB7245bd260Cc9753911Be
 COUNCIL_SAFE=0xf64bc17485f0B4Ea5F06A96514182FC4cB561977
 FOUNDATION_SAFE=0xDEe57160aAfCF04c34C887B5962D0a69676d3C8B
 OWNER_SAFE=0x1Eb2fFc903729a0F03966B917003800b145F56E2

diff --git a/tasks/sep/fp-recovery/005-set-game-implementation/NestedSignFromJson.s.sol b/tasks/sep/fp-recovery/005-set-game-implementation/NestedSignFromJson.s.sol
@@ -28,8 +28,6 @@ contract NestedSignFromJson is OriginalNestedSignFromJson {
     address livenessGuard = 0xc26977310bC89DAee5823C2e2a73195E85382cC7;
 
     // Known EOAs to exclude from safety checks.
-    address l2OutputOracleProposer; // cast call $L2OO "PROPOSER()(address)"
-    address l2OutputOracleChallenger; // In registry addresses.
     address systemConfigOwner; // In registry addresses.
     address batchSenderAddress; // In registry genesis-system-configs
     address p2pSequencerAddress; // cast call $SystemConfig "unsafeBlockSigner()(address)"

diff --git a/tasks/sep/fp-recovery/005-set-game-implementation/README.md b/tasks/sep/fp-recovery/005-set-game-implementation/README.md
@@ -1,4 +1,4 @@
-# Deputy Guardian - Enable Permissioness Dispute Game
+# ProxyAdminOwner - Set Dispute Game Implementation
 
 Status: CONTINGENCY TASK, SIGN AS NEEDED
 

diff --git a/tasks/sep/fp-recovery/005-set-game-implementation/justfile b/tasks/sep/fp-recovery/005-set-game-implementation/justfile
@@ -9,7 +9,7 @@ generate-input gameType='' implAddr='':
   #!/usr/bin/env bash
   set -euo pipefail
   . .env
-  SET_GAME_TYPE_SIG="setImplementation(uint32, address)"
+  SET_GAME_TYPE_SIG="setImplementation(uint32,address)"
   ENCODED_CALL=$(cast calldata "${SET_GAME_TYPE_SIG}" "{{gameType}}" "{{implAddr}}")
 
   REGISTRY_DIR="../../../../lib/superchain-registry"