Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

challenger: Transition to invalid hash at superroot boundaries #14034

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

Description

Update the challenger to check the CrossSafeDerivedFrom field of super root responses to determine if the claim is unsafe.
Doesn't yet handle transitioning at the first optimistic block that is unsafe because we will need to know what block number needs to be safe for each chain at the next timestamp to calculate that. Currently the challenger doesn't ever parse the rollup config so it doesn't have that info - will need some more plumbing to actually load rollup configs (we have them available as we pass them through to op-program).

Tests

Added unit tests. This doesn't get any more action tests passing as the chains aren't actually long enough to hit these cases. Will need to improve the action tests but avoiding conflicts with other PRs for now.

Metadata

Part of #13903

Doesn't yet handle transitioning at the first optimistic block that is unsafe.
@ajsutton ajsutton requested review from a team as code owners January 29, 2025 03:25
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.01%. Comparing base (d39eb24) to head (3c29244).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14034      +/-   ##
===========================================
- Coverage    47.04%   47.01%   -0.04%     
===========================================
  Files          975      975              
  Lines        81768    81776       +8     
===========================================
- Hits         38468    38444      -24     
- Misses       40410    40445      +35     
+ Partials      2890     2887       -3     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (ø)
cannon-go-tests-64 56.62% <ø> (ø)
contracts-bedrock-tests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-challenger/game/fault/trace/super/provider.go 75.86% <100.00%> (+2.44%) ⬆️

... and 9 files with indirect coverage changes

@ajsutton ajsutton requested a review from Inphi January 30, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant