Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: update interop optimistic block system deposit tx sender address #14023

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

protolambda
Copy link
Contributor

Description

Small interop code update, to match ethereum-optimism/specs#536

@protolambda protolambda added the H-interop Hardfork: change planned for interop upgrade label Jan 28, 2025
@protolambda protolambda added this to the Interop: Stable Devnet milestone Jan 28, 2025
@protolambda protolambda requested review from a team as code owners January 28, 2025 17:48
@protolambda protolambda requested a review from ajsutton January 28, 2025 17:48
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.56%. Comparing base (7d6d154) to head (3b40b9a).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14023      +/-   ##
===========================================
- Coverage    46.90%   46.56%   -0.34%     
===========================================
  Files          974      974              
  Lines        81670    81670              
  Branches       759      759              
===========================================
- Hits         38307    38032     -275     
- Misses       40377    40710     +333     
+ Partials      2986     2928      -58     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.62% <ø> (-1.66%) ⬇️
contracts-bedrock-tests 87.68% <ø> (-2.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/interop/managed/attributes.go 86.90% <100.00%> (ø)

... and 36 files with indirect coverage changes

@tynes tynes added this pull request to the merge queue Jan 29, 2025
Merged via the queue into develop with commit 500d1fe Jan 29, 2025
44 checks passed
@tynes tynes deleted the interop-optimistic-block-deposit-tx-fix branch January 29, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H-interop Hardfork: change planned for interop upgrade
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants