-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proofs: Add action test for unhappy consolidation #14019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14019 +/- ##
============================================
- Coverage 46.51% 0 -46.52%
============================================
Files 989 0 -989
Lines 83614 0 -83614
============================================
- Hits 38892 0 -38892
+ Misses 41785 0 -41785
+ Partials 2937 0 -2937
Flags with carried forward coverage won't be shown. Click here to find out more. |
ccfd125
to
1ba5263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looking into the CI failures. This PR conflicts with the recent super root RPC change. |
blocking merge until #14042 is merged. |
The test covers the unhappy path in the consolidation step of the fault proof where an invalid message triggers a block replacement
81b176d
to
f1d8bac
Compare
The test covers the unhappy path in the consolidation step of the fault proof where an invalid message triggers a block replacement.
Note that the invalid block test cases where moved from
TestInteropProofs
to a new test.This patch also contains fixes for the deposits only block build done when replacing an invalid optimistic block.