Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proofs: Add action test for unhappy consolidation #14019

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Jan 28, 2025

The test covers the unhappy path in the consolidation step of the fault proof where an invalid message triggers a block replacement.
Note that the invalid block test cases where moved from TestInteropProofs to a new test.

This patch also contains fixes for the deposits only block build done when replacing an invalid optimistic block.

@Inphi Inphi requested review from ajsutton and clabby January 28, 2025 15:22
@Inphi Inphi requested review from a team as code owners January 28, 2025 15:22
@Inphi Inphi requested a review from protolambda January 28, 2025 15:22
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e08bd0f) to head (f1d8bac).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14019       +/-   ##
============================================
- Coverage    46.51%        0   -46.52%     
============================================
  Files          989        0      -989     
  Lines        83614        0    -83614     
============================================
- Hits         38892        0    -38892     
+ Misses       41785        0    -41785     
+ Partials      2937        0     -2937     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 989 files with indirect coverage changes

@Inphi Inphi force-pushed the inphi/consolidation-test branch from ccfd125 to 1ba5263 Compare January 28, 2025 15:26
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

op-e2e/actions/interop/interop_test.go Outdated Show resolved Hide resolved
@Inphi Inphi enabled auto-merge January 29, 2025 01:53
@Inphi Inphi added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@ajsutton ajsutton added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@Inphi
Copy link
Contributor Author

Inphi commented Jan 29, 2025

Looking into the CI failures. This PR conflicts with the recent super root RPC change.

@Inphi Inphi added the M-do-not-merge Meta: Do not merge label Jan 29, 2025
@Inphi
Copy link
Contributor Author

Inphi commented Jan 29, 2025

blocking merge until #14042 is merged.

@Inphi Inphi removed the M-do-not-merge Meta: Do not merge label Jan 30, 2025
Inphi added 3 commits January 30, 2025 02:17
The test covers the unhappy path in the consolidation step of the fault
proof where an invalid message triggers a block replacement
@Inphi Inphi force-pushed the inphi/consolidation-test branch from 81b176d to f1d8bac Compare January 30, 2025 07:18
@Inphi Inphi enabled auto-merge January 30, 2025 07:18
@Inphi Inphi added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit cf7a37b Jan 30, 2025
43 checks passed
@Inphi Inphi deleted the inphi/consolidation-test branch January 30, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants