FaultDisputeGame.sol: make code and comment consistent #13999
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
reviewed
Jan 27, 2025
There was a problem hiding this comment.
This change looks fine to me. Will defer to @ControlCplusControlV / @smartcontracts on whether we want to merge.
|
/ci authorize 5167067 |
|
Going to block this for now, we can consider merging as part of the next release, I don't want to make any logical changes (even changes that shouldn't impact logic at all) outside of the standard contract release process |
smartcontracts
requested changes
Jan 27, 2025
|
But I'm in favor of including this for Upgrade 14 |
zhiqiangxu
force-pushed
the
opt_verifyExecBisectionRoot
branch
from
9e7a1aa to
da5d411
Compare
|
/ci authorize da5d411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the code more consistent with the comment:
The
disputedpart is only necessary when the move is a defense.The bytecode increases 4 bytes from:
to:
but I think the clarity is worth it.