Draft: OPUpdatePrestate #13998
Draft: OPUpdatePrestate #13998
Conversation
packages/contracts-bedrock/scripts/deploy/updater-deployment-out.md
Outdated
Show resolved
Hide resolved
JosepBove
force-pushed
the
opcm/updatePrestateHash
branch
from
a81ef76 to
62a8fe6
Compare
JosepBove
force-pushed
the
opcm/updatePrestateHash
branch
from
65ffef4 to
3565fbb
Compare
There was a problem hiding this comment.
This file is looking pretty good to me.
| ); | ||
| } | ||
|
|
||
| function test_updatePrestate_succeeds() public { |
There was a problem hiding this comment.
even if they aren't written yet, it will speed up the process if you could add empty test functions for other cases that we'll add here.
Ie. just:
function test_updatePrestate_emptyPrestate_fails(){}
that way we can make sure we're on the same page about what tests are needed.
There was a problem hiding this comment.
Added my tests, let's talk about the ones that you think are missing on the meeting. Probably testing that 2 inputs work and get correctly reordered if we have fdg and pdg
| bool hasFDG = Claim.unwrap(_prestateUpdateInputs[i].absolutePrestate) != bytes32(0); | ||
| AddGameInput[] memory inputs = new AddGameInput[](hasFDG ? 2 : 1); | ||
| AddGameInput memory pdgInput; | ||
| AddGameInput memory fdgInput; | ||
|
|
||
| if (Claim.unwrap(_prestateUpdateInputs[i].absolutePrestate) == bytes32(0)) { |
There was a problem hiding this comment.
How can we use Claim.unwrap(_prestateUpdateInputs[i].absolutePrestate) != bytes32(0) to determine if there is a FDG when we also revert if Claim.unwrap(_prestateUpdateInputs[i].absolutePrestate) == bytes32(0)?
I'd have expected we determine if there's a FDG by seeing if DisputeGameFactory.gameImpls(GameTypes.CANNON) != address(0).
There was a problem hiding this comment.
Agree, that check looks wrong. Should be similar to here
There was a problem hiding this comment.
OK, I see. This line dates to when we were accepting an absolutePrestate for each game, and so providing one for the fdg was just taken as an indication that it exists.
Accepting a single absolutePrestate, then querying to see if there is an FDG is a better approach.
JosepBove
force-pushed
the
opcm/updatePrestateHash
branch
from
9a145b8 to
b326e30
Compare
No description provided.