-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Descope liquidity migration interop #13978
feat: Descope liquidity migration interop #13978
Conversation
/ci authorize 2ad048c |
This is good but we should also not set the other contracts involved in this in genesis. It does mean that a slight refactor to the tests are necessary. The contracts are: setOptimismSuperchainERC20Factory(); // 26
setOptimismSuperchainERC20Beacon(); // 27 |
/ci authorize 4da62d3 |
Thank you @agusduha! This looks good to me, will merge on CI passing |
Looks like linting/test errors |
sorry about that ci be annoying -_- |
@tynes No problem, it was my bad for not running semgrep, btw I believe that |
/ci approve 0cb0dfe |
/ci authorize 0cb0dfe |
Looks like tests are failing for unknown reason |
I will try syncing with develop to see if it's resolved |
/ci authorize afcbb84 |
https://app.codecov.io/gh/ethereum-optimism/optimism/pull/13978 hitting a bug with codecov.
|
Something is broken with ci codecov, do you mind rebasing? sorry about that. it could be the recent merge commit |
6430775
#13929