Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Descope liquidity migration interop #13978

Conversation

gotzenx
Copy link
Contributor

@gotzenx gotzenx commented Jan 24, 2025

@gotzenx gotzenx requested a review from tynes January 24, 2025 21:45
@gotzenx gotzenx requested a review from a team as a code owner January 24, 2025 21:45
@tynes
Copy link
Contributor

tynes commented Jan 28, 2025

/ci authorize 2ad048c

@tynes
Copy link
Contributor

tynes commented Jan 28, 2025

This is good but we should also not set the other contracts involved in this in genesis. It does mean that a slight refactor to the tests are necessary.

The contracts are:

            setOptimismSuperchainERC20Factory(); // 26
            setOptimismSuperchainERC20Beacon(); // 27

https://github.com/ethereum-optimism/optimism/blob/e3a320152d067c0083d18835220d938c822210d7/packages/contracts-bedrock/scripts/L2Genesis.s.sol#L280C1-L281C54

@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

/ci authorize 4da62d3

@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

Thank you @agusduha! This looks good to me, will merge on CI passing

@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

Looks like linting/test errors

@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

sorry about that ci be annoying -_-

@agusduha
Copy link
Contributor

agusduha commented Jan 29, 2025

@tynes No problem, it was my bad for not running semgrep, btw I believe that just semgrep should be inside the pre-pr to avoid missing it

@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

/ci approve 0cb0dfe

@tynes tynes enabled auto-merge January 29, 2025 22:08
@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

/ci authorize 0cb0dfe

@tynes
Copy link
Contributor

tynes commented Jan 29, 2025

Looks like tests are failing for unknown reason

@agusduha
Copy link
Contributor

I will try syncing with develop to see if it's resolved

@tynes
Copy link
Contributor

tynes commented Jan 30, 2025

/ci authorize afcbb84

@tynes
Copy link
Contributor

tynes commented Jan 30, 2025

https://app.codecov.io/gh/ethereum-optimism/optimism/pull/13978

hitting a bug with codecov.

Unable to compare commits because the head commit was not found.

@tynes
Copy link
Contributor

tynes commented Jan 30, 2025

Something is broken with ci codecov, do you mind rebasing? sorry about that. it could be the recent merge commit

@tynes
Copy link
Contributor

tynes commented Jan 30, 2025

@tynes tynes added this pull request to the merge queue Jan 31, 2025
Merged via the queue into ethereum-optimism:develop with commit 6430775 Jan 31, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants