feat: use v4 engine APIs when Isthmus enabled #13976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize 871efb6 |
|
@meyer9 what are your plans with this PR? |
|
oh nvm looks like the relevant changes were already merged |
meyer9
force-pushed
the
meyer9/call-new-payload-v4
branch
from
871efb6 to
3a3de57
Compare
|
/ci authorize 3a3de57 |
tynes
reviewed
Jan 29, 2025
| req[i] = hex[i] | ||
| } | ||
| return req | ||
| } |
There was a problem hiding this comment.
I was wondering if its possible to do this in a 1 liner but doesn't seem possible without unsafe
// Warning: not recommended for production.
func convertRequestsUnsafe(hex []hexutil.Bytes) [][]byte {
return *(*[][]byte)(unsafe.Pointer(&hex))
}
tynes
reviewed
Jan 29, 2025
| @@ -352,6 +357,36 @@ func (ea *L2EngineAPI) NewPayloadV3(ctx context.Context, params *eth.ExecutionPa | |||
| return ea.newPayload(ctx, params, versionedHashes, beaconRoot, nil) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This looks right to me but not sure if there is something else missing in here. cc @Inphi
tynes
reviewed
Jan 29, 2025
| return ð.PayloadStatusV1{Status: eth.ExecutionInvalid}, engine.InvalidParams.With(errors.New("nil executionRequests post-prague")) | ||
| } | ||
|
|
||
| if !ea.config().IsIsthmus(uint64(params.Timestamp)) { |
There was a problem hiding this comment.
I don't notice test coverage of this case
|
/ci authorize 3a3de57 |
|
Looks like there was some sort of deadlock? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Optimism to use payload v4 methods when Isthmus is enabled.
Tests
Updates existing tests following v3 example.