ci: Remove CI builder #13965
Merged
ci: Remove CI builder #13965
+135
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
force-pushed
the
feat/remove-ci-builder
branch
from
65ed7a6 to
7901124
Compare
ajsutton
reviewed
Jan 24, 2025
mslipper
force-pushed
the
feat/remove-ci-builder
branch
from
ca4f04f to
a347a67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13965 +/- ##
===========================================
- Coverage 46.37% 46.27% -0.11%
===========================================
Files 994 994
Lines 83950 83950
===========================================
- Hits 38936 38847 -89
- Misses 42069 42170 +101
+ Partials 2945 2933 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
mslipper
force-pushed
the
feat/remove-ci-builder
branch
from
458b4e8 to
2acfa7f
Compare
We were using both Docker-based CI builder images as well as self-hosted runner images with software preinstalled. This was causing discrepancies between software versions when things were updated. Furthermore, changing `mise.toml` required a manual rebuild of the CI builder image for changes to take effect. This PR updates the CI pipeline to use Mise to install all tool necessary to run the monorepo. Preinstalled tools have been removed from the self-hosted runners, and all Docker images in the pipeline have been replaced with a simple `cimg/base` image.
mslipper
force-pushed
the
feat/remove-ci-builder
branch
from
2acfa7f to
551d012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using both Docker-based CI builder images as well as self-hosted runner images with software preinstalled. This was causing discrepancies between software versions when things were updated. Furthermore, changing
mise.tomlrequired a manual rebuild of the CI builder image for changes to take effect.This PR updates the CI pipeline to use Mise to install all tool necessary to run the monorepo. Preinstalled tools have been removed from the self-hosted runners, and all Docker images in the pipeline have been replaced with a simple
cimg/baseimage. Data is cached to minimize installation time between runs.This PR has been tested with self-hosted images that have had the majority of pre-installed tools removed. To make the pipeline work while this PR is reviewed, I've put those tools back. When this is ready to merge I'll uninstall them again. Note that this PR will require a rebase of all open PRs.