[Superchain Ops] Integration Testing Fork Test #13960
Conversation
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
| bool useOpsRepo = bytes(vm.envOr("STATE_PATH", string(""))).length > 0; | ||
| if (useOpsRepo) { | ||
| console.log("ForkLive: loading state from %s", vm.envString("STATE_PATH")); | ||
| vm.loadAllocs(vm.envString("STATE_PATH")); |
There was a problem hiding this comment.
I think it would be useful to include a comment here to say why the order of commands matters here e.g. why don't we 'loadAllocs' after '_readSuperchainRegistry'?
There was a problem hiding this comment.
superchain ops might do an upgrade and so we want to be able to pull the logic contracts from the newly updated values instead of the stale values in the current registry.
There was a problem hiding this comment.
Right, I believe @blmalone is suggesting to add that as a code comment which is a good idea :)
Also one clarification would be "...from the newly updated values instead of reading the current implementation addresses from the forked chain", since the implementations are read via calls here, not read from the superchain registry
Signed-off-by: Elliot <[email protected]>
Signed-off-by: Elliot <[email protected]>
|
/ci authorize f505a15 |
|
/ci authorize f505a15 |
1 similar comment
|
/ci authorize f505a15 |
Co-authored-by: Matt Solomon <[email protected]>
|
/ci authorize ed0e121 |
Signed-off-by: Elliot <[email protected]>
|
/ci authorize 3a7df1e |
Description
This PR paves the way for fork testing using the state diff result of a task from superchain ops.
Additional context
Superchain ops integration testing will allow us to run the integration tests after the superchain ops task state changes are applied.
Metadata
Include a link to any github issues that this may close in the following form: