-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote ivanvc to approver for etcd website #938
Conversation
Signed-off-by: James Blair <[email protected]>
/lgtm Well deserved! I wanted to raise the same proposal long time ago. A big THANK YOU to @ivanvc ! |
/approve |
... what else does this PR require to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contributions @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jberkus, jmhbnz, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As outlined in https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/community-membership.md#maintainers
We currently have support from 4/8 existing members of @etcd-io/maintainers-website group. Which is not a super majority. However there is a lazy consensus of three business weeks specified in https://github.com/etcd-io/etcd/blob/main/GOVERNANCE.md we can fall back on. This does probably call into question if @chalin and @nate-double-u should still be listed as approvers still given they have not made any commits to the repo in last 12 months and are cncf staff vs etcd project team per se. @chalin, @nate-double-u can you please let us know if we should be removing you as maintainers for this repository? Thanks. |
Hi James, I know I trailed off a bit last year, but I'm happy to stay on--I'm still an approver over on kubernetes/website, and can extend my work there to cover etcd-io/website. I've also got access to the Kubernetes-Docs Netlify team, so I'm happy to help with any website CI issues that might come up. |
Gah, I forgot about the supermajority thing. We should probably change that. |
LGTM |
Merging 6/8 maintainers appear supportive for this pr which is a super majority. |
Reviewing the last 12 months contribution data https://github.com/etcd-io/website/graphs/contributors?from=6%2F01%2F2024 @ivanvc has been our top contributor to the etcd.io website.
Their contributions have been high quality, helped reduce toil and improve the state of this repository, including key items such as:
Additionally they have helped discuss and review many of the proposed pr's for this repository since joining the project https://github.com/etcd-io/website/pulls?q=is%3Apr+comment-by%3A%40ivanvc+.
@ivanvc is already a reviewer for
etcd-io/etcd
and a trusted member of our release team so with this pull request I propose we recognise their efforts here by promoting them to an approver foretcd-io/website
.cc @etcd-io/maintainers-website