Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote ivanvc to approver for etcd website #938

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Jan 5, 2025

Reviewing the last 12 months contribution data https://github.com/etcd-io/website/graphs/contributors?from=6%2F01%2F2024 @ivanvc has been our top contributor to the etcd.io website.

Their contributions have been high quality, helped reduce toil and improve the state of this repository, including key items such as:

Additionally they have helped discuss and review many of the proposed pr's for this repository since joining the project https://github.com/etcd-io/website/pulls?q=is%3Apr+comment-by%3A%40ivanvc+.

@ivanvc is already a reviewer for etcd-io/etcd and a trusted member of our release team so with this pull request I propose we recognise their efforts here by promoting them to an approver for etcd-io/website.

cc @etcd-io/maintainers-website

@ahrtr
Copy link
Member

ahrtr commented Jan 6, 2025

/lgtm
/approve

Well deserved! I wanted to raise the same proposal long time ago. A big THANK YOU to @ivanvc !

@jberkus
Copy link
Contributor

jberkus commented Jan 6, 2025

/approve
/lgtm

@jberkus
Copy link
Contributor

jberkus commented Jan 6, 2025

... what else does this PR require to merge?

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contributions @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jberkus, jmhbnz, spzala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jberkus,jmhbnz,spzala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz
Copy link
Member Author

jmhbnz commented Jan 6, 2025

... what else does this PR require to merge?

As outlined in https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/community-membership.md#maintainers

Defined by: approvers entry in the OWNERS file.

Sponsored by two active maintainers and elected by supermajority

Sponsors must be from multiple member companies to demonstrate integration across the community.

We currently have support from 4/8 existing members of @etcd-io/maintainers-website group. Which is not a super majority. However there is a lazy consensus of three business weeks specified in https://github.com/etcd-io/etcd/blob/main/GOVERNANCE.md we can fall back on.

This does probably call into question if @chalin and @nate-double-u should still be listed as approvers still given they have not made any commits to the repo in last 12 months and are cncf staff vs etcd project team per se.

@chalin, @nate-double-u can you please let us know if we should be removing you as maintainers for this repository? Thanks.

@nate-double-u
Copy link
Contributor

Hi James,

I know I trailed off a bit last year, but I'm happy to stay on--I'm still an approver over on kubernetes/website, and can extend my work there to cover etcd-io/website. I've also got access to the Kubernetes-Docs Netlify team, so I'm happy to help with any website CI issues that might come up.

@jberkus
Copy link
Contributor

jberkus commented Jan 7, 2025

Gah, I forgot about the supermajority thing. We should probably change that.

@serathius
Copy link
Member

LGTM

@jmhbnz
Copy link
Member Author

jmhbnz commented Jan 7, 2025

Merging 6/8 maintainers appear supportive for this pr which is a super majority.

@jmhbnz jmhbnz merged commit de58fb1 into etcd-io:main Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants