-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver: add learner check to readyz #19086
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gojoy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gojoy. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9bdee08
to
58de027
Compare
@siyuanfoundation Hi. Can you review this request |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 29 files with indirect coverage changes @@ Coverage Diff @@
## main #19086 +/- ##
==========================================
- Coverage 68.75% 68.72% -0.04%
==========================================
Files 420 420
Lines 35640 35646 +6
==========================================
- Hits 24506 24497 -9
- Misses 9705 9716 +11
- Partials 1429 1433 +4 Continue to review full report in Codecov by Sentry.
|
lgtm overall. Can you fix the tiny error in the verify test? |
Signed-off-by: GitHub <[email protected]>
/retest-required |
done |
error in the verify test has been fixed. please review again @siyuanfoundation |
fix #19001