Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the minRev between syncWatchers loops #18996

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Keep the minRev between syncWatchers loops

c8fee01
Select commit
Loading
Failed to load commit list.
Draft

Keep the minRev between syncWatchers loops #18996

Keep the minRev between syncWatchers loops
c8fee01
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2024 in 0s

68.70% (-0.13%) compared to b038739

View this Pull Request on Codecov

68.70% (-0.13%) compared to b038739

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.70%. Comparing base (b038739) to head (c8fee01).

Files with missing lines Patch % Lines
server/storage/mvcc/watchable_store.go 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/watchable_store.go 91.50% <33.33%> (-1.44%) ⬇️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18996      +/-   ##
==========================================
- Coverage   68.82%   68.70%   -0.13%     
==========================================
  Files         420      420              
  Lines       35621    35627       +6     
==========================================
- Hits        24517    24476      -41     
- Misses       9683     9718      +35     
- Partials     1421     1433      +12     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b038739...c8fee01. Read the comment docs.