Watch sync refactor

[serathius]

Split off #18975

[serathius]

cc @ahrtr @jmhbnz

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (3d46df1) to head (3741000).
Report is 10 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/storage/mvcc/watchable_store.go	92.80% <100.00%> (-0.67%)	⬇️

... and 20 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18976   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         420      420           
  Lines       35598    35599    +1     
=======================================
+ Hits        24483    24484    +1     
- Misses       9685     9686    +1     
+ Partials     1430     1429    -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d46df1...3741000. Read the comment docs.

[serathius]

Verify fails on master and integration tests seem flaky.
cc @jmhbnz @ivanvc
Maybe we could have periodic for integration tests?

[serathius]

/retest

[ahrtr]

LGTM

Thanks for the nice refactoring.

[ahrtr]

Nice!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivanvc]

Verify fails on master and integration tests seem flaky. cc @jmhbnz @ivanvc Maybe we could have periodic for integration tests?

Sounds like a good idea. I'll open a PR.