Support specifying MaxBytes in range request #16300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added label |
wenjiaswe
reviewed
Jul 26, 2023
wenjiaswe
reviewed
Sep 14, 2023
linxiulei
force-pushed
the
size_paging
branch
from
7091145 to
65d3aeb
Compare
|
/lgtm |
|
failed test seems flaky to me |
ahrtr
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Raised a couple of minor comment on copy/pastes typos, and a major comment in #14809 (comment)
| @@ -296,6 +300,8 @@ func OpPut(key, val string, opts ...OpOption) Op { | |||
| panic("unexpected filter in put") | |||
| case ret.createdNotify: | |||
| panic("unexpected createdNotify in put") | |||
| case ret.maxBytes != 0: | |||
| panic("unexpected maxBytes in delete") | |||
There was a problem hiding this comment.
Suggested change
| panic("unexpected maxBytes in delete") | |
| panic("unexpected maxBytes in put") |
| @@ -323,6 +329,8 @@ func opWatch(key string, opts ...OpOption) Op { | |||
| panic("unexpected mod revision filter in watch") | |||
| case ret.minCreateRev != 0, ret.maxCreateRev != 0: | |||
| panic("unexpected create revision filter in watch") | |||
| case ret.maxBytes != 0: | |||
| panic("unexpected maxBytes in delete") | |||
There was a problem hiding this comment.
Suggested change
| panic("unexpected maxBytes in delete") | |
| panic("unexpected maxBytes in watch") |
linxiulei
force-pushed
the
size_paging
branch
from
65d3aeb to
710ced8
Compare
Signed-off-by: Eric Lin <[email protected]>
Signed-off-by: Eric Lin <[email protected]>
Run 1. ./scripts/genproto.sh 2. ./scripts/update_proto_annotations.sh Signed-off-by: Eric Lin <[email protected]>
Signed-off-by: Eric Lin <[email protected]>
Signed-off-by: Eric Lin <[email protected]>
Signed-off-by: Eric Lin <[email protected]>
linxiulei
force-pushed
the
size_paging
branch
from
710ced8 to
d48d3e2
Compare
|
Discussed during sig-etcd triage meeting, @linxiulei should we close this for now given a KEP is required before we could progress it (as discussed in linked issue). |
|
This is superseded with https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/3157-watch-list/README.md, on the other hand etcd should think about our own WatchList :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #14809
Please also refer to previously closed PR