Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'go 1.23.0' to 'go 1.23' in go.mod #41

Closed
wants to merge 1 commit into from
Closed

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 15, 2025

@k8s-ci-robot
Copy link

@ahrtr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-operator-test-e2e 38cec61 link false /test pull-etcd-operator-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@soma00333
Copy link
Contributor

We may need to add go mod tidy to the lint workflow.

- name: Run golangci-lint
run: |
make lint

cf. https://github.com/etcd-io/etcd-operator/actions/runs/12786609848/job/35644009662?pr=41

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Jan 16, 2025

Since k8s.io./* modules already specify "go 1.23.0" in their go.mod files, so each time when we execute "go mod tidy", it will automatically change "go 1.23" to "go 1.23.0". technically It isn't a problem to specify "go 1.23.0", so closing this PR...

FYI. https://groups.google.com/g/golang-nuts/c/6JcXf_KZBR0

@ahrtr ahrtr closed this Jan 16, 2025
@ahrtr ahrtr deleted the go_20250115 branch January 16, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants