-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make verify target for running static analysis checks #34
Conversation
Agreed - Thanks @henrybear327 Note: Please ensure your commit is signed so the developer certificate of origin check passes. |
969260f
to
9ab8987
Compare
32d96d1
to
4c53f6f
Compare
Commits are now fixed with proper signing! Thanks for pointing it out! |
Thanks for the feedback! :) I have updated the linter target and added For the linter, I took the linter config file from |
4c53f6f
to
c00e611
Compare
Don't forget to signoff every commit :) |
One nit comment. Otherwise LGTM. |
Changes: - Introduce `make verify` and `make fmt` targets in Makefile - For linter, use the same config as etcd repo - Update GitHubCI workflow accordingly Closes etcd-io#31 References: - fmt and lint https://github.com/etcd-io/bbolt/blob/c57b3537ed933f2e613f04d42688d49e511f69b3/Makefile#L30C1-L36C84 - fmt script https://github.com/etcd-io/etcd/blob/a08812eb01572aa64479543d1e8fa33cda22b8b8/scripts/fix.sh - GithubCI https://github.com/etcd-io/etcd/blob/a08812eb01572aa64479543d1e8fa33cda22b8b8/.github/workflows/static-analysis.yaml - linter config https://github.com/etcd-io/etcd/blob/a08812eb01572aa64479543d1e8fa33cda22b8b8/tools/.golangci.yaml Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
c00e611
to
60f0e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @henrybear327
Add Makefile targets for running fmt and static analysis checks
Changes:
make verify
andmake fmt
targets in MakefileCloses #31
References: