Add new workflow for static analysis checks & address lint errors #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Blair <[email protected]>
jmhbnz
force-pushed
the
add-static-analysis-workflow
branch
3 times, most recently
from
fdc4088 to
c9b7994
Compare
jmhbnz
changed the title
jmhbnz
commented
Mar 21, 2024
| @@ -98,6 +98,7 @@ func init() { | |||
| // | |||
| // After this, RawExtensions in Kubernetes types will serialize kube-aggregator types | |||
| // correctly. | |||
| //nolint:errcheck | |||
There was a problem hiding this comment.
We have a work in progress pr in relation to scheme so don't want to waste time sorting our error checking here for now so just added the nolint:errcheck
Signed-off-by: James Blair <[email protected]>
jmhbnz
force-pushed
the
add-static-analysis-workflow
branch
from
c9b7994 to
1ea9209
Compare
|
LGTM. We should also add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a basic new github actions workflow for running
golangci-lintso we can keep on top of this moving forward.In a second commit I've also quickly gone through all the lint errors and made an initial rushed attempt at fixing them, @siyuanfoundation can you please take a close look at these.