Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defunct makefile recipes for release #157

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

mathias-goebel
Copy link
Contributor

closes #156

go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.
make: *** [/go/src/github.com/etcd-io/auger/Makefile:67: release-docker-build] Error 1
make: *** [Makefile:55: release] Error 2

Makefile Outdated Show resolved Hide resolved
@jmhbnz
Copy link
Member

jmhbnz commented Nov 16, 2024

/retitle Remove defunct makefile recipes for release

@k8s-ci-robot k8s-ci-robot changed the title fix: disable VCS stamping Remove defunct makefile recipes for release Nov 16, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mathias-goebel thanks for tidying this all up, just need to sign commit and we are good to merge, i.e:

git reset --soft HEAD~2
git commit -s -m "Remove defunct makefile recipes for release."
git push --force

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, mathias-goebel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 94f9420 into etcd-io:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing build with make release
3 participants